Check php compatibility of app store app releases #24416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
reviewed
Nov 27, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Apps might increase the minimum php version requirement, in which case an update could break the app or even the whole instance. We must not install those releases, or better, don't even show them for update/installation. This extends the app fetcher code to filter out the releases that are not installable. The filter respects minimum and maximum requirements. E.g. apps that are still only released for php7.3 won't show up for php7.4 instances. This behavior is new but if an app lists an explicit version requirement, then we ought to repect that. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/app-store-check-php-compat
branch
from
f6260a2 to
24237f1
Compare
ChristophWurst
requested review from
julien-nc,
juliusknorr,
nickvergessen and
rullzer
ChristophWurst
added
3. to review
2 tasks
juliusknorr
approved these changes
Dec 7, 2020
Member
Author
|
🏓 please review :) |
rullzer
approved these changes
Dec 10, 2020
Member
Author
|
/backport to stable20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apps might increase the minimum php version requirement, in which case
an update could break the app or even the whole instance. We must not
install those releases, or better, don't even show them for
update/installation. This extends the app fetcher code to filter out the
releases that are not installable.
The filter respects minimum and maximum requirements. E.g. apps that are
still only released for php7.3 won't show up for php7.4 instances. This
behavior is new but if an app lists an explicit version requirement,
then we ought to repect that.
Apps to test this with are
twofactor_totp,twofactor_u2fandocras those three only allow php7.3 if we go by the info.xml.S/o to @nickvergessen for the very useful pointers.