Fix some php 8 warnings #26494
Merged
Fix some php 8 warnings #26494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvoisin
approved these changes
May 29, 2021
PHP 8 shows deprecation warnings about this, see #25806 Removes the "default" values, as they actually are required parameters anyway. Signed-off-by: Richard de Boer <[email protected]>
…eger PHP 8 shows deprecation warnings about this, see #25806 Signed-off-by: Richard de Boer <[email protected]>
Before we just turned it off and @Suppressed the error if ob was not active. In PHP 8 this error is no longer suppressed, so try to not cause it at all. Signed-off-by: Richard de Boer <[email protected]>
Contributor
Author
|
Rebased onto master. ( |
Contributor
|
@MorrisJobke @kesselb @acsfer Review Please :) |
Contributor
|
@rigrig is this already part of the list [PHP] Error: Required parameter $mode follows optional parameter $a at /var/www/nextcloud/core/Controller/PreviewController.php#155 |
AndyXheli
approved these changes
Jun 7, 2021
MorrisJobke
approved these changes
Jun 7, 2021
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Code makes sense and cleans it nicely up 👍
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Member
|
/backport to stable21 |
Contributor
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PHP 8 warnings mentioned in #25806:
This only fixes the PHP 8 warnings, not deprecation warnings by
3rdpartycode.