Skip to content

Fix some php 8 warnings #26494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 3 commits into from
Jun 7, 2021
Merged

Fix some php 8 warnings #26494

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f23d057
Fix functions taking optional parameters before required ones
rigrig Apr 10, 2021
a0d265b
Fix a usort comparison function returning a boolean instead of an int…
rigrig Apr 10, 2021
7990f95
Check whether output buffering is active before turning it off
rigrig Apr 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Check whether output buffering is active before turning it off 
Before we just turned it off and @Suppressed the error if ob was not active.
In PHP 8 this error is no longer suppressed, so try to not cause it at all.

Signed-off-by: Richard de Boer <[email protected]>
  • Loading branch information
@rigrig
rigrig committed May 29, 2021
commit 7990f95558ac2b7fac3b9f77dcbdc3c74b05785b
8 changes: 6 additions & 2 deletions lib/private/Files/View.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,9 @@ public function filesize($path) {
*/
public function readfile($path) {
$this->assertPathLength($path);
@ob_end_clean();
if (ob_get_level()) {
ob_end_clean();
}
$handle = $this->fopen($path, 'rb');
if ($handle) {
$chunkSize = 524288; // 512 kB chunks
Expand All @@ -446,7 +448,9 @@ public function readfile($path) {
*/
public function readfilePart($path, $from, $to) {
$this->assertPathLength($path);
@ob_end_clean();
if (ob_get_level()) {
ob_end_clean();
}
$handle = $this->fopen($path, 'rb');
if ($handle) {
$chunkSize = 524288; // 512 kB chunks
Expand Down