Skip to content

Properly cleanup entries of WebAuthn on user deletion #27532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Jun 18, 2021
Merged

Properly cleanup entries of WebAuthn on user deletion #27532

MorrisJobke merged 1 commit into from
Jun 18, 2021

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Jun 16, 2021

Add listener on user deletion to clean up the webauthn table.

@MorrisJobke MorrisJobke added enhancement 3. to review Waiting for reviews labels Jun 16, 2021
@MorrisJobke MorrisJobke added this to the Nextcloud 22 milestone Jun 16, 2021
LukasReschke
LukasReschke approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@LukasReschke
Copy link
Member

LukasReschke commented Jun 16, 2021

/backport to stable21

@LukasReschke
Copy link
Member

LukasReschke commented Jun 16, 2021

/backport to stable20

@LukasReschke
Copy link
Member

LukasReschke commented Jun 16, 2021

/backport to stable19

@blizzz blizzz mentioned this pull request Jun 17, 2021
Merged
45 tasks
ChristophWurst
ChristophWurst approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 18, 2021
@MorrisJobke MorrisJobke force-pushed the fix/noid/properly-cleanup-webauthn-user-deletion branch from c07d414 to dbed0ce Compare June 18, 2021 07:42
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Jun 18, 2021

Code style fixed ✅

@MorrisJobke MorrisJobke merged commit 38edc6f into master Jun 18, 2021
@MorrisJobke MorrisJobke deleted the fix/noid/properly-cleanup-webauthn-user-deletion branch June 18, 2021 10:52
This was referenced Jun 18, 2021
Closed
Closed
Closed
@LukasReschke LukasReschke mentioned this pull request Jun 22, 2021
Merged
@LukasReschke
Copy link
Member

LukasReschke commented Jun 22, 2021

Manual backport at #27596

@blizzz blizzz mentioned this pull request Jun 23, 2021
Merged
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasReschke LukasReschke LukasReschke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@blizzz blizzz Awaiting requested review from blizzz

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke @LukasReschke @ChristophWurst