Skip to content

[stable20] Properly cleanup entries of WebAuthn on user deletion #27596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LukasReschke merged 3 commits into from
Jun 22, 2021
Merged

[stable20] Properly cleanup entries of WebAuthn on user deletion #27596

LukasReschke merged 3 commits into from
Jun 22, 2021

Conversation

@LukasReschke
Copy link
Member

@LukasReschke LukasReschke commented Jun 22, 2021

Backport of #27532

@LukasReschke LukasReschke added this to the Nextcloud 20.0.11 milestone Jun 22, 2021
@LukasReschke
Copy link
Member Author

LukasReschke commented Jun 22, 2021

/backport to stable19

@LukasReschke
Copy link
Member Author

LukasReschke commented Jun 22, 2021

/backport to stable21

@LukasReschke LukasReschke mentioned this pull request Jun 22, 2021
Merged
@LukasReschke LukasReschke added the 3. to review Waiting for reviews label Jun 22, 2021
@LukasReschke
Copy link
Member Author

LukasReschke commented Jun 22, 2021 

/home/runner/work/server/server/lib/private/Authentication/WebAuthn/Db/PublicKeyCredentialMapper.php:95:8:error - UndefinedInterfaceMethod: Method OCP\DB\QueryBuilder\IQueryBuilder::executeStatement does not exist

😢

@LukasReschke LukasReschke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jun 22, 2021
@LukasReschke LukasReschke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 22, 2021
@LukasReschke
Remove throwing annotation
5a1faab 
This class was just introduced in Nc 21.

Signed-off-by: Lukas Reschke <[email protected]>
@LukasReschke
Copy link
Member Author

LukasReschke commented Jun 22, 2021

Failing tests seem unrelated. Merging as this is a backport of Morris.

@LukasReschke LukasReschke merged commit d969686 into stable20 Jun 22, 2021
@LukasReschke LukasReschke deleted the stable20-backport-27532 branch June 22, 2021 13:48
This was referenced Jun 22, 2021
Merged
Merged
@blizzz blizzz mentioned this pull request Jun 23, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 20.0.11

Development

Successfully merging this pull request may close these issues.

4 participants

@LukasReschke @ChristophWurst @MorrisJobke