Skip to content

Improve provider check #28078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kesselb merged 1 commit into from
Jul 21, 2021
Merged

Improve provider check #28078

kesselb merged 1 commit into from
Jul 21, 2021

Conversation

@LukasReschke
Copy link
Member

@LukasReschke LukasReschke commented Jul 21, 2021 •
edited
Loading

Check if there is a provider missing.

Test plan

  • Enforce Two Factor in the Admin Settings
  • Ensure that setup of Two Factor in the login screen still works
  • Ensure that Two Factor login still works

@LukasReschke
Improve provider check
04fa36d 
Check if there is a provider missing.

Signed-off-by: Lukas Reschke <[email protected]>
@LukasReschke LukasReschke added the 3. to review Waiting for reviews label Jul 21, 2021
@LukasReschke LukasReschke added this to the Nextcloud 20.0.12 milestone Jul 21, 2021
@LukasReschke
Copy link
Member Author

LukasReschke commented Jul 21, 2021

/backport to stable22

@LukasReschke
Copy link
Member Author

LukasReschke commented Jul 21, 2021

/backport to stable21

@LukasReschke
Copy link
Member Author

LukasReschke commented Jul 21, 2021

/backport to stable20

@kesselb kesselb merged commit 41eec84 into master Jul 21, 2021
@kesselb kesselb deleted the refine-middleware branch July 21, 2021 13:23
This was referenced Jul 21, 2021
Merged
Merged
Merged
@ChristophWurst ChristophWurst mentioned this pull request Nov 23, 2021
Closed
@ChristophWurst ChristophWurst mentioned this pull request Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@kesselb kesselb kesselb approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

4 participants

@LukasReschke @juliusknorr @kesselb