Fix setting up 2FA when no providers are set up but backup codes #30193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2FA set up is allowed when only backup codes are set up but no other provider and no provider is failing. This patch syncs up the login controller check with the challenge controller check 10 lines above. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
requested review from
LukasReschke,
miaulalala and
nickvergessen
miaulalala
approved these changes
Dec 10, 2021
nickvergessen
approved these changes
Dec 13, 2021
ChristophWurst
deleted the
fix/set-up-2fa-no-providers-but-backup-codes
branch
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable21 |
This was referenced Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2FA set up is allowed when only backup codes are set up but no other
provider and no provider is failing.
This patch syncs up the login controller check with the challenge
controller check 10 lines above.
Fixes nextcloud/twofactor_totp#1160
Side effect/regression of #28078