Skip to content

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Aug 16, 2021

Description

This change allows to start every app in its own standalone window which is very cool for some apps that you might want to access directly from the startmenu of your OS without needing to open the browser and clicking on a favorite or app inside Nextcloud first. It applies to any app if the theming app is enabled.

Example: Files app

Before After
image image
image image

Standalone window will afterwards look like this

image

Signed-off-by: szaimen [email protected]

@szaimen szaimen added the 2. developing Work in progress label Aug 16, 2021
@szaimen szaimen added this to the Nextcloud 23 milestone Aug 16, 2021
@szaimen szaimen force-pushed the enh/noid/improve-webmanifest-2 branch 8 times, most recently from af9f345 to f1eeb3d Compare August 23, 2021 11:42
@szaimen szaimen marked this pull request as ready for review August 23, 2021 12:32
@szaimen szaimen added 3. to review Waiting for reviews enhancement feature: theming and removed 2. developing Work in progress labels Aug 23, 2021
@szaimen
Copy link
Contributor Author

szaimen commented Aug 23, 2021

/backport to stable22

@szaimen szaimen changed the title improve webmanifest Allow to open any app in a standalone window Aug 23, 2021
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Works fine with an empty app summary.

@julien-nc
Copy link
Member

Additional hint to try this PR:
To add a website as an app on Chromium based browsers, open the hamburger menu -> more tools -> create shortcut

@szaimen szaimen requested a review from a team August 23, 2021 13:46
@szaimen szaimen force-pushed the enh/noid/improve-webmanifest-2 branch 4 times, most recently from e8cbb67 to 544f2df Compare August 23, 2021 17:06
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

@bessw

This comment has been minimized.

@szaimen

This comment has been minimized.

Signed-off-by: szaimen <[email protected]>
@szaimen szaimen force-pushed the enh/noid/improve-webmanifest-2 branch from 544f2df to 0758e02 Compare August 24, 2021 09:42
@szaimen
Copy link
Contributor Author

szaimen commented Aug 24, 2021

@juliushaertl are you fine when I merge this or is there still something that needs to be addressed?

@szaimen
Copy link
Contributor Author

szaimen commented Aug 25, 2021

Thanks for the approval! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants