Prepare for group mentions in talk (and comments?) #29140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
requested review from
a team,
PVince81,
blizzz and
skjnldsv
and removed request for
a team
skjnldsv
approved these changes
Oct 11, 2021
vitormattos
reviewed
Oct 11, 2021
vitormattos
left a comment
vitormattos
left a comment
There was a problem hiding this comment.
Because the regular expression is already big, it's good to have unit test with possible match scenarios
7 tasks
Signed-off-by: Joas Schilling <[email protected]>
Member
Author
|
Tests are already there and are now extended |
vitormattos
approved these changes
Oct 12, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequirement for nextcloud/spreed#6339