-
Notifications
You must be signed in to change notification settings - Fork 508
Group mentions #6340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Group mentions #6340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b6f359 to
13468e8
Compare
6c52d20 to
36ddb7d
Compare
6a12861 to
1a8bdcc
Compare
1a8bdcc to
3b6381d
Compare
3b6381d to
d6d50be
Compare
d6d50be to
42eb198
Compare
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
c7cbbd8 to
4ffc854
Compare
Signed-off-by: Joas Schilling <[email protected]>
vitormattos
suggested changes
Mar 14, 2023
Contributor
vitormattos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A problem at integration test:
File: tests/integration/features/chat/notifications.feature:293
Scenario: Group-mention when group is not a member of the room # /drone/server/apps/spreed/tests/integration/features/chat/notifications.feature:293
When user "participant1" creates room "room" (v4) # FeatureContext::userCreatesRoom()
| roomType | 2 |
| roomName | room |
And user "participant1" adds user "participant2" to room "room" with 200 (v4) # FeatureContext::userAddAttendeeToRoom()
Given user "participant2" joins room "room" with 200 (v4) # FeatureContext::userJoinsRoom()
When user "participant1" sends message 'Hi @"group/attendees1" bye' to room "room" with 201 # FeatureContext::userSendsMessageToRoom()
Then user "participant2" has the following notifications # FeatureContext::userNotifications()
| app | object_type | object_id | subject |
Notifications count does not match
Failed asserting that actual size 1 matches expected size 0.
Member
Author
|
Forgot to git add ... |
…conversation Signed-off-by: Joas Schilling <[email protected]>
31cf464 to
2c201f9
Compare
vitormattos
approved these changes
Mar 15, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
icon-group-forced-white+ group displaynameicon-group-forced-white+ group displaynameRef #6339