Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 8, 2021

  • Requires Prepare for group mentions in talk (and comments?) server#29140
  • Mention API returns groups which are tracked
  • When generating notifications for mentions group members need to be notified
    • Check for conflict with replying
    • Check that the group is a member of the room
  • Render group mention suggestion in the input field with icon-group-forced-white + group displayname
  • Render group mentions in messages with icon-group-forced-white + group displayname

Ref #6339

@nickvergessen nickvergessen added this to the 💖 Next Major (23) milestone Oct 12, 2021
@nickvergessen nickvergessen force-pushed the feature/6339/group-mentions branch from 3b6f359 to 13468e8 Compare October 13, 2021 10:13
@vitormattos vitormattos force-pushed the feature/6339/group-mentions branch from 6c52d20 to 36ddb7d Compare October 13, 2021 11:08
@nickvergessen nickvergessen force-pushed the feature/6339/group-mentions branch 2 times, most recently from 6a12861 to 1a8bdcc Compare January 21, 2022 15:13
@nickvergessen nickvergessen force-pushed the feature/6339/group-mentions branch from 1a8bdcc to 3b6381d Compare March 16, 2022 10:11
@nickvergessen nickvergessen force-pushed the feature/6339/group-mentions branch from 3b6381d to d6d50be Compare April 1, 2022 09:46
@nickvergessen nickvergessen removed this from the v15.0.0-beta.4 milestone Sep 15, 2022
@nickvergessen nickvergessen force-pushed the feature/6339/group-mentions branch from c7cbbd8 to 4ffc854 Compare March 13, 2023 10:16
@nickvergessen nickvergessen marked this pull request as ready for review March 13, 2023 10:17
@nickvergessen nickvergessen self-assigned this Mar 13, 2023
Signed-off-by: Joas Schilling <[email protected]>
Copy link
Contributor

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A problem at integration test:

File: tests/integration/features/chat/notifications.feature:293

  Scenario: Group-mention when group is not a member of the room                                # /drone/server/apps/spreed/tests/integration/features/chat/notifications.feature:293
    When user "participant1" creates room "room" (v4)                                           # FeatureContext::userCreatesRoom()
      | roomType | 2    |
      | roomName | room |
    And user "participant1" adds user "participant2" to room "room" with 200 (v4)               # FeatureContext::userAddAttendeeToRoom()
    Given user "participant2" joins room "room" with 200 (v4)                                   # FeatureContext::userJoinsRoom()
    When user "participant1" sends message 'Hi @"group/attendees1" bye' to room "room" with 201 # FeatureContext::userSendsMessageToRoom()
    Then user "participant2" has the following notifications                                    # FeatureContext::userNotifications()
      | app | object_type | object_id | subject |
      Notifications count does not match
      Failed asserting that actual size 1 matches expected size 0.

@nickvergessen
Copy link
Member Author

Forgot to git add ...

@nickvergessen nickvergessen force-pushed the feature/6339/group-mentions branch from 31cf464 to 2c201f9 Compare March 14, 2023 17:11
@nickvergessen nickvergessen merged commit 651a7a9 into master Mar 16, 2023
@nickvergessen nickvergessen deleted the feature/6339/group-mentions branch March 16, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants