-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Drop PHP7.3 #29286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop PHP7.3 #29286
Conversation
|
It seems a lot of images in .drone.yml use PHP 7.3. It also needs to be removed from .github/workflows/oci.yml |
I can use my script to drop this from all the app repositories. |
|
It would be good to finish and merge this before 8.1 is added to CI to avoid queuing too much jobs. |
|
@ChristophWurst ready when you are 😉 |
101925a to
d7af5f8
Compare
|
CI needs adjustment. Feel free to take over. |
|
The following images still need 7.4 equivalents: |
You can trigger them in https://github.com/nextcloud/docker-ci/actions/workflows/docker.yml |
I actually cannot: "Error: The user required level is not sufficient" |
+ DietPi-Software | Nextcloud: Assure that Nextcloud v23 is installed on Stretch and Buster, since v24 will drop support for PHP7.3: nextcloud/server#29286
@come-nc you have been promoted :) |
d58fa32 to
f896cba
Compare
e6b2488 to
1dad710
Compare
6585724 to
d33489c
Compare
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
d33489c to
910e1aa
Compare
|
@nickvergessen All tests are finally passing, except samba which is broken as well on master. So what are the next steps to get this merged? |
|
I will bump all apps friday, after that is in we can merge this here |
|
#30896 Review time |
|
Good to merge then? |
Fixes #29258
Todo
composer update phpTo be merged once 23 is branched off.