Always call flush() as getAllKeys() is broken #30769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
requested review from
a team,
icewind1991,
nickvergessen and
skjnldsv
and removed request for
a team
nickvergessen
approved these changes
Jan 20, 2022
skjnldsv
approved these changes
Jan 20, 2022
Member
|
Backports? |
skjnldsv
added
the
feature: caching
CarlSchwan
approved these changes
Jan 20, 2022
Member
CarlSchwan
left a comment
CarlSchwan
left a comment
There was a problem hiding this comment.
And I would backport it :)
Member
|
/backport to stable23 |
Member
|
/backport to stable22 |
Member
|
/backport to stable21 |
Member
|
Let's backport after the current releases |
come-nc
added
4. to release
This was referenced Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix memcached test on PHP 7.4 which is failing in CI of #29286
Context:
PHP documentation for Memcached::getAllKeys states:
Memcached::getAllKeys() queries each memcache server and retrieves an array of all keys stored on them at that point in time. This is not an atomic operation, so it isn't a truly consistent snapshot of the keys at point in time. As memcache doesn't guarantee to return all keys you also cannot assume that all keys have been returned.
https://www.php.net/manual/en/memcached.getallkeys.php
In the 7.4 CI getAllKeys is always returning an empty array. As the documentation suggets that even if not empty the method may return incomplete result, I just always do a complete flush.
Signed-off-by: Côme Chilliet [email protected]