-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Show most recently deleted files first in trash can #29611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show most recently deleted files first in trash can #29611
Conversation
Signed-off-by: Orzu Ionut <[email protected]>
6e0a01b to
33c1c5c
Compare
|
/compile / |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work in my testing 👍
tested with
docker run -it \
-e SERVER_BRANCH=newroco:bugfix/16412/show-most-recently-deleted-files-first \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.130 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest
Thanks for fixing this! 🚀
|
But @orzuionut please fix |
Signed-off-by: Orzu Ionut <[email protected]>
|
Thanks! Looks like the jsunit test needs an adjustment now:
|
Signed-off-by: Orzu Ionut <[email protected]>
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Failure unrelated, afaics.
|
Test failure is indeed unrelated (user settings) |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
|
The backport to stable20 failed. Please do this backport manually. |
|
The backport to stable22 failed. Please do this backport manually. |
|
The backport to stable21 failed. Please do this backport manually. |
Fix #16412