Skip to content

Conversation

@orzuionut
Copy link
Contributor

@orzuionut orzuionut commented Nov 9, 2021

Fix #16412

@putt1ck putt1ck requested a review from jancborchardt November 9, 2021 14:37
@orzuionut orzuionut force-pushed the bugfix/16412/show-most-recently-deleted-files-first branch from 6e0a01b to 33c1c5c Compare November 9, 2021 15:00
@szaimen szaimen added this to the Nextcloud 23 milestone Nov 9, 2021
@szaimen
Copy link
Contributor

szaimen commented Nov 9, 2021

/compile /

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work in my testing 👍

tested with
docker run -it \
-e SERVER_BRANCH=newroco:bugfix/16412/show-most-recently-deleted-files-first \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.130 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

Thanks for fixing this! 🚀

@szaimen
Copy link
Contributor

szaimen commented Nov 9, 2021

But @orzuionut please fix Node / node (pull_request) by compiling the js code and pushing the production js here. Thanks! :)

Signed-off-by: Orzu Ionut <[email protected]>
@szaimen
Copy link
Contributor

szaimen commented Nov 10, 2021

Thanks! Looks like the jsunit test needs an adjustment now:

expect(fileList._sortDirection).toEqual('asc');

Signed-off-by: Orzu Ionut <[email protected]>
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Failure unrelated, afaics.

@CarlSchwan
Copy link
Member

Test failure is indeed unrelated (user settings)

@CarlSchwan CarlSchwan merged commit f5954a2 into nextcloud:master Nov 10, 2021
@welcome
Copy link

welcome bot commented Nov 10, 2021

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@szaimen
Copy link
Contributor

szaimen commented Nov 10, 2021

/backport to stable22

@szaimen
Copy link
Contributor

szaimen commented Nov 10, 2021

/backport to stable21

@szaimen
Copy link
Contributor

szaimen commented Nov 10, 2021

/backport to stable20

@szaimen szaimen mentioned this pull request Nov 10, 2021
@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When opening the trashbin it doesn't show the most recently deleted files first.

4 participants