Skip to content

Show most recently deleted files first in trash can #29611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlSchwan merged 3 commits into from
Nov 10, 2021
Merged

Show most recently deleted files first in trash can #29611

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33c1c5c
Show most recently deleted files first in trash can
orzuionut Nov 9, 2021
5b07584
Compile JS code
orzuionut Nov 10, 2021
00c23cc
Update filelist test
orzuionut Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/files_trashbin/lib/Trash/TrashManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function listTrashRoot(IUser $user): array {
return array_merge($items, $backend->listTrashRoot($user));
}, []);
usort($items, function (ITrashItem $a, ITrashItem $b) {
return $a->getDeletedTime() - $b->getDeletedTime();
return $b->getDeletedTime() - $a->getDeletedTime();
});
return $items;
}
Expand Down
2 changes: 1 addition & 1 deletion apps/files_trashbin/src/filelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
this.$el.find('.undelete').click('click', _.bind(this._onClickRestoreSelected, this))

// Sort by most recently deleted first
this.setSort('mtime', 'asc')
this.setSort('mtime', 'desc')

/**
* Override crumb making to add "Deleted Files" entry
Expand Down