Ignore non-existing groups when notifying group shares #30281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
requested review from
CarlSchwan,
artonge,
miaulalala and
nickvergessen
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
Group shares might exist even after a group got deleted. This fix catches the situation and discards the notification for the obsolete group. Signed-off-by: Vincent Petry <[email protected]> Co-authored-by: Joas Schilling <[email protected]>
PVince81
force-pushed
the
bugfix/30280/fix-confused-notifier-with-null-group
branch
from
53a69a0 to
4559a46
Compare
artonge
approved these changes
Dec 16, 2021
icewind1991
approved these changes
Dec 16, 2021
skjnldsv
approved these changes
Dec 16, 2021
CarlSchwan
approved these changes
Dec 16, 2021
PVince81
deleted the
bugfix/30280/fix-confused-notifier-with-null-group
branch
This was referenced Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30280
Group shares might exist even after a group got deleted.
To prevent log pollution when fetching notifications, this fix catches
the non-existing group situation and throws a different exception that
gets ignored. Without this, the log will contain an error about calling
inGroup on null.
The solution uses the same approach (InvalidArgumentException) that exists already in the code for the case where the user is null.
But this doesn't solve the mystery why deleting a group doesn't delete the share... there might be a cron job that does so at some point but I'm not sure