Skip to content

Ignore non-existing groups when notifying group shares #30281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 1 commit into from
Dec 17, 2021
Merged

Ignore non-existing groups when notifying group shares #30281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Discard share notification for non-existing groups 
Group shares might exist even after a group got deleted.

This fix catches the situation and discards the notification for the
obsolete group.

Signed-off-by: Vincent Petry <[email protected]>
Co-authored-by: Joas Schilling <[email protected]>
  • Loading branch information
@PVince81 @nickvergessen
PVince81 and nickvergessen committed Dec 15, 2021
commit 4559a46c8d9497e9d923ea6c6cd8b7cf14729b1b
2 changes: 1 addition & 1 deletion apps/files_sharing/lib/Notification/Notifier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ protected function parseShareInvitation(IShare $share, INotification $notificati
}

$group = $this->groupManager->get($share->getSharedWith());
if (!$group->inGroup($user)) {
if ($group === null || !$group->inGroup($user)) {
throw new AlreadyProcessedException();
}

Expand Down