Skip to content

Conversation

@skjnldsv
Copy link
Member

Before After
2021-12-28_15-19 2021-12-28_15-17_1
2021-12-28_15-20 2021-12-28_15-17

Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv requested review from a team, PVince81, Pytal and artonge and removed request for a team December 28, 2021 14:21
@skjnldsv skjnldsv self-assigned this Dec 28, 2021
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: files labels Dec 28, 2021
@skjnldsv skjnldsv added this to the Nextcloud 24 milestone Dec 28, 2021
@skjnldsv
Copy link
Member Author

/backport to stable23

@skjnldsv
Copy link
Member Author

/backport to stable22

@skjnldsv
Copy link
Member Author

/backport to stable21

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement so green from my side, but wouldn't it be better to vertically align the two lines with the row, like we do in listitem and listitemicon?

Screenshot 2021-12-29 at 11 01 18

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

color: var(--color-text-maxcontrast);
text-overflow: ellipsis;
white-space: nowrap;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
overflow: hidden;
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, actually it's broken because of the absolute. It has no effect, maybe for a later rewrite 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it works in grid view...

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 4, 2022

Definitely an improvement so green from my side, but wouldn't it be better to vertically align the two lines with the row, like we do in listitem and listitemicon?

Well, that ain't gonna be a fix for now considering all the mess there is with absolute positioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants