Skip to content

Fix uploading text position #30423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Jan 4, 2022
Merged

Fix uploading text position #30423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix uploading text position 
Signed-off-by: John Molakvoæ <[email protected]>
  • Loading branch information
@skjnldsv
skjnldsv committed Dec 28, 2021
commit e0b02c095a773f7941d5d6ad8fdd932aca928bbb
34 changes: 25 additions & 9 deletions apps/files/css/files.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,11 +428,6 @@ table {
padding: 0 20px 0 0;
}
}

.uploadtext {
position: absolute;
left: 55px;
}
}

.hide-hidden-files #filestable #fileList tr.hidden-file,
Expand Down Expand Up @@ -460,13 +455,22 @@ table td.filename .nametext .innernametext {
/* for smaller resolutions - see mobile.css */

table td.filename .uploadtext {
position: absolute;
font-weight: normal;
margin-left: 55px;
margin-top: 5px;
// checkbox width
margin-left: 50px;
left: 0;
bottom: 0;
height: 20px;
padding: 10px 0;
padding: 0 4px;
// align with file name
padding-left: 1px;
font-size: 11px;
opacity: .5;
// double the font size
line-height: 22px;
color: var(--color-text-maxcontrast);
text-overflow: ellipsis;
white-space: nowrap;
}
Copy link
Contributor

@szaimen szaimen Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
overflow: hidden;
}

Copy link
Member Author

@skjnldsv skjnldsv Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, actually it's broken because of the absolute. It has no effect, maybe for a later rewrite 🤷

Copy link
Contributor

@szaimen szaimen Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it works in grid view...


table td.selection {
Expand Down Expand Up @@ -988,6 +992,18 @@ table.dragshadow td.size {
}
}

.uploadtext {
width: 100%;
margin: 0;
top: 0;
bottom: auto;
// checkbox align
height: 28px;
padding-top: 4px;
// checkbox margins
padding-left: calc(44px - 16px);
}

.name {
height: 100%;
border-radius: var(--border-radius);
Expand Down