Skip to content

[stable22] add better index for finding unindexed paths #30598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaIng merged 1 commit into from
Jan 13, 2022
Merged

[stable22] add better index for finding unindexed paths #30598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add better index for finding unindexed paths 
for the following query 'SELECT "path" FROM "oc_filecache" WHERE ("storage" = $storage) AND ("size" < 0) ORDER BY "fileid" DESC LIMIT 1;'

currently the database will in some cases decide to priorize the sort by fileid over the filter when picking what index to use, resulting in a much slower query.

by creating an index that allows first sorting by fileid and also filter by storage and size this case will be greatly sped up

Signed-off-by: Robin Appelman <[email protected]>
  • Loading branch information
@icewind1991
icewind1991 committed Jan 13, 2022
commit 9f2b50db193796bdc61ddeb61116b25e26f8614e
4 changes: 4 additions & 0 deletions core/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@ function (GenericEvent $event) use ($container) {
if (!$table->hasIndex('fs_storage_path_prefix') && !$schema->getDatabasePlatform() instanceof PostgreSQL94Platform) {
$subject->addHintForMissingSubject($table->getName(), 'fs_storage_path_prefix');
}

if (!$table->hasIndex('fs_id_storage_size')) {
$subject->addHintForMissingSubject($table->getName(), 'fs_id_storage_size');
}
}

if ($schema->hasTable('twofactor_providers')) {
Expand Down
7 changes: 7 additions & 0 deletions core/Command/Db/AddMissingIndices.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,13 @@ private function addCoreIndexes(OutputInterface $output) {
$updated = true;
$output->writeln('<info>Filecache table updated successfully.</info>');
}
if (!$table->hasIndex('fs_id_storage_size')) {
$output->writeln('<info>Adding additional size index to the filecache table, this can take some time...</info>');
$table->addIndex(['fileid', 'storage', 'size'], 'fs_id_storage_size');
$this->connection->migrateToSchema($schema->getWrappedSchema());
$updated = true;
$output->writeln('<info>Filecache table updated successfully.</info>');
}
}

$output->writeln('<info>Check indices of the twofactor_providers table.</info>');
Expand Down
1 change: 1 addition & 0 deletions core/Migrations/Version13000Date20170718121200.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $op
$table->addIndex(['storage', 'mimetype'], 'fs_storage_mimetype');
$table->addIndex(['storage', 'mimepart'], 'fs_storage_mimepart');
$table->addIndex(['storage', 'size', 'fileid'], 'fs_storage_size');
$table->addIndex(['fileid', 'storage', 'size'], 'fs_id_storage_size');
$table->addIndex(['mtime'], 'fs_mtime');
$table->addIndex(['size'], 'fs_size');
if (!$schema->getDatabasePlatform() instanceof PostgreSQL94Platform) {
Expand Down