[stable23] Fix psalm not running #30814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
CarlSchwan,
ChristophWurst,
come-nc,
juliusknorr,
nickvergessen and
skjnldsv
Member
|
@CarlSchwan can you have a look? :) |
Member
|
This needs a I will try to do it tonight unless someone beat me to it before ;) |
CarlSchwan
force-pushed
the
backport/30508/stable23
branch
2 times, most recently
from
e6001f7 to
c60321f
Compare
Member
|
I hope the tests will pass now :) |
Member
|
Same for stable22 :) |
CarlSchwan
force-pushed
the
backport/30508/stable23
branch
from
c60321f to
ae9c810
Compare
Member
|
@skjnldsv This PR should be good now :) The issue with 'Code scanning results / Psalm' is that it is comparing with stable23 and as we updated the psalm dependency the comparison fails. This will fix itself automatically once merged, as new PR will compare against the new baseline. |
CarlSchwan
force-pushed
the
backport/30508/stable23
branch
from
ae9c810 to
01cb494
Compare
Member
|
/me forgot to run cs:fixer 😭 |
CarlSchwan
force-pushed
the
backport/30508/stable23
branch
2 times, most recently
from
a9abdb7 to
283b4cf
Compare
MichaIng
added
3. to review
MichaIng
approved these changes
Jan 25, 2022
CarlSchwan
force-pushed
the
backport/30508/stable23
branch
2 times, most recently
from
6a6f469 to
f43fcd2
Compare
Member
|
Please edit the checker :) |
The issue was that we were using psalm/phar instead of vimeo/psalm. This caused issue with the custom psalm plugin in buildd/psalm. This is using the opportunity to also update the psalm version from 3.8 to 3.17 and the php-cs-fixer too. Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
backport/30508/stable23
branch
from
f43fcd2 to
d69531a
Compare
skjnldsv
approved these changes
Jan 27, 2022
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #30508