Fix psalm not running

[CarlSchwan]

The issue was that we were using psalm/phar instead of vimeo/psalm. This
caused issue with the custom psalm plugin in build/psalm not using the same
php class anymore since HumbugBox was used as prefixed for the class inside
the phar.

This is using the opportunity to also update the psalm version from 3.8
to 3.18 and the php-cs-fixer too. This also consequentially updates the baseline.
There is, unfortunately, some recent regression for psalm that most of them seem
to be caused by recent commits and also a few false positives from psalm.

Signed-off-by: Carl Schwan [email protected]

[CarlSchwan]

:(

./vendor-bin/psalm/vendor/vimeo/psalm/psalm --update-baseline Works perfectly

composer psalm:update-baseline generate the broken baseline and doesn't report errors

I looked and both are using the same version and composer psalm:update-baseline should just call the binary inside lib/composer/bin that calls ./vendor-bin/psalm/vendor/vimeo/psalm/psalm internally. But it seems there is something broken in the way this is done...

Fixed

[CarlSchwan]

Works now locally :) Let's hope the ci is also happy

[CarlSchwan]

The fact that Code scanning results / Psalm is failing is expected since it compares the baselines from the master and not with the baseline stored in the repo. There are due to the update to psalm 3.18 some new issues and also some issues that disappeared. There is nothing I can do about this, but once merged this failing CI should fix itself.

[nickvergessen]

Good apart from the one return

[skjnldsv]

/backport 47c9c34 to stable22

[skjnldsv]

/backport 47c9c34 to stable23

[backportbot-nextcloud]

The backport to stable22 failed. Please do this backport manually.