Skip to content

[stable22] Fix psalm #30826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 2 commits into from
Jan 27, 2022
Merged

[stable22] Fix psalm #30826

skjnldsv merged 2 commits into from
Jan 27, 2022

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Jan 24, 2022

Backport of #30508

@skjnldsv
Copy link
Member

skjnldsv commented Jan 24, 2022

Code scanning results / Psalm Failing after 23s — 24 new alerts including 7 errors, 24 fixes

@CarlSchwan CarlSchwan force-pushed the backport/stable22/psalm-fix branch from 44d9555 to 78e0af1 Compare January 24, 2022 12:33
@CarlSchwan
Fix psalm
0262cc3 
Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan CarlSchwan force-pushed the backport/stable22/psalm-fix branch from 78e0af1 to 0262cc3 Compare January 24, 2022 12:34
@MichaIng
Copy link
Member

MichaIng commented Jan 25, 2022

Hmm 24 new and 24 fixed would be expected, but now it is 27 new and 24 fixed 🤔.

Some annotations are clear mistakes, like (!foo === bar) while meant was surely (foo !== bar) 😄. Shall we fix this right here or in a dedicated PR? The one in apps/user_ldap/lib/Access.php has been fixed in #30508 as well.

@MichaIng MichaIng added this to the Nextcloud 22.2.4 milestone Jan 25, 2022
@skjnldsv skjnldsv mentioned this pull request Jan 25, 2022
Merged
5 tasks
@CarlSchwan CarlSchwan force-pushed the backport/stable22/psalm-fix branch from ef63120 to 7fbb9df Compare January 26, 2022 11:59
@skjnldsv
Copy link
Member

skjnldsv commented Jan 27, 2022

Please edit the checker :)

ERROR: There were 2 additional files:
223 | .php-cs-fixer.dist.php
224 | vendor-bin
225 | ERROR: There were 1 missing files:
226 | .php_cs.dist

@CarlSchwan CarlSchwan force-pushed the backport/stable22/psalm-fix branch from 7fbb9df to a9605e4 Compare January 27, 2022 16:18
@CarlSchwan
Psalm fixing
57514e4 
Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan CarlSchwan force-pushed the backport/stable22/psalm-fix branch from a9605e4 to 57514e4 Compare January 27, 2022 16:21
@skjnldsv skjnldsv merged commit c0b2972 into stable22 Jan 27, 2022
@skjnldsv skjnldsv deleted the backport/stable22/psalm-fix branch January 27, 2022 19:05
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 27, 2022
@kesselb kesselb mentioned this pull request Jun 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@MichaIng MichaIng MichaIng approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug technical debt

Projects

None yet

Milestone

Nextcloud 22.2.4

Development

Successfully merging this pull request may close these issues.

4 participants

@CarlSchwan @skjnldsv @MichaIng