Skip to content

Fix federated cloud share icons overlap in button #31596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artonge merged 1 commit into from
Mar 17, 2022
Merged

Fix federated cloud share icons overlap in button #31596

artonge merged 1 commit into from
Mar 17, 2022

Conversation

@Lucarnosky
Copy link
Contributor

@Lucarnosky Lucarnosky commented Mar 16, 2022 •
edited by CarlSchwan
Loading

Added margin right the the icon to avoid overlap over the write

Fix #30819

@szaimen szaimen added this to the Nextcloud 24 milestone Mar 16, 2022
@szaimen szaimen added the 3. to review Waiting for reviews label Mar 16, 2022
@szaimen szaimen requested review from a team, artonge, skjnldsv and vanpertsch and removed request for a team March 16, 2022 16:54
@CarlSchwan CarlSchwan changed the title Fix issue #30819 Fix federated cloud share icons overlap in button Mar 16, 2022
@CarlSchwan
Copy link
Member

CarlSchwan commented Mar 16, 2022

Thanks! This looks good to me :)

Please fix the DCO https://github.com/nextcloud/server/pull/31596/checks?check_run_id=5573597201 :)

@artonge
Copy link
Contributor

artonge commented Mar 16, 2022

Did you test the solution? Couldn't get it to work.

@szaimen
Copy link
Contributor

szaimen commented Mar 16, 2022

Did you test the solution? Couldn't get it to work.

yes, that is also what I thought... margin right doesn't seem right...

@CarlSchwan
Copy link
Member

CarlSchwan commented Mar 16, 2022

Padding left is probably more likely to work

artonge
artonge requested changes Mar 16, 2022
View reviewed changes
Lucarnosky added a commit to Lucarnosky/server that referenced this pull request Mar 16, 2022
@Lucarnosky
Changed to padding left nextcloud#31596
3131d52
@Lucarnosky
Copy link
Contributor Author

Lucarnosky commented Mar 16, 2022

Fixed

@artonge
Copy link
Contributor

artonge commented Mar 17, 2022

All good :)

@Lucarnosky can you fix DCO? https://github.com/nextcloud/server/pull/31596/checks?check_run_id=5578043641

Lucarnosky added a commit to Lucarnosky/server that referenced this pull request Mar 17, 2022
@Lucarnosky
Changed to padding left nextcloud#31596 Signed-off-by: Lucarnosky <lu…
d5739aa 
…[email protected]>

Fix issue nextcloud#30819

Fixed issue nextcloud#30819
@Lucarnosky
Copy link
Contributor Author

Lucarnosky commented Mar 17, 2022

@artonge
Squashed and add self signed. Let me know if everything is ok now

@artonge
Copy link
Contributor

artonge commented Mar 17, 2022 •
edited
Loading

@artonge Squashed and add self signed. Let me know if everything is ok now

Signed-off is present, but I think it needs to be at the end of the commit message

Lucarnosky added a commit to Lucarnosky/server that referenced this pull request Mar 17, 2022
@Lucarnosky
Changed to padding left nextcloud#31596
3ea53c3 
Fix issue nextcloud#30819

Fixed issue nextcloud#30819

Signed-off-by: Lucarnosky <[email protected]>
@Lucarnosky
Copy link
Contributor Author

Lucarnosky commented Mar 17, 2022

@artonge Squashed and add self signed. Let me know if everything is ok now

Signed-off is present, but I think it needs to be at the end of the commit message

Sorry for the mess, fixed the commit

@artonge
Copy link
Contributor

artonge commented Mar 17, 2022

Sorry for the mess, fixed the commit

Commit sha: 3ea53c3, Author: Lock Garnock, Committer: Lock Garnock; Expected "Lock Garnock [email protected]", but got "Lucarnosky [email protected]".

SHould be "Lock Garnock" instead of "Lucarnosky"

@Lucarnosky
Copy link
Contributor Author

Lucarnosky commented Mar 17, 2022

Sorry for the mess, fixed the commit

Commit sha: 3ea53c3, Author: Lock Garnock, Committer: Lock Garnock; Expected "Lock Garnock [email protected]", but got "Lucarnosky [email protected]".

SHould be "Lock Garnock" instead of "Lucarnosky"

DCO Passed :)

@artonge artonge merged commit 4011a39 into nextcloud:master Mar 17, 2022
@welcome
Copy link

welcome bot commented Mar 17, 2022

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@artonge
Copy link
Contributor

artonge commented Mar 17, 2022

Thanks for this @Lucarnosky ! :)

@Lucarnosky
Copy link
Contributor Author

Lucarnosky commented Mar 17, 2022

Thank you guys for patience and amazing work. Glad to contribute

@artonge artonge mentioned this pull request Apr 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@vanpertsch vanpertsch Awaiting requested review from vanpertsch

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

Federated cloud share icons overlap in button

4 participants

@Lucarnosky @CarlSchwan @artonge @szaimen