Skip to content

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Apr 25, 2022

Fix #31970

Before After
image image

Signed-off-by: szaimen [email protected]

For my own testing
docker run -it \
-e SERVER_BRANCH=fix/31970/fix-social-sharing-buttons \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Apr 25, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Apr 25, 2022
@szaimen szaimen force-pushed the fix/31970/fix-social-sharing-buttons branch from 61dcffd to 6600bc5 Compare April 25, 2022 15:48
@szaimen szaimen requested review from a team, PVince81, artonge and skjnldsv and removed request for a team April 25, 2022 15:54
@szaimen
Copy link
Contributor Author

szaimen commented Apr 25, 2022

/backport to stable24

@szaimen
Copy link
Contributor Author

szaimen commented Apr 25, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Apr 25, 2022

/backport to stable22

@szaimen
Copy link
Contributor Author

szaimen commented Apr 26, 2022

/rebase

@artonge
Copy link
Contributor

artonge commented Apr 26, 2022

Wasn't it fixed by #31596 ?

@szaimen
Copy link
Contributor Author

szaimen commented Apr 26, 2022

Wasn't it fixed by #31596 ?

seems like not... I must admin I didn't test the mentioned PR and did not find it when looking for it hence I create this one...
Either way the !important has missed from the mentioned PR...

@szaimen szaimen force-pushed the fix/31970/fix-social-sharing-buttons branch from 6600bc5 to dfa14c7 Compare April 26, 2022 14:42
@CarlSchwan CarlSchwan added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 27, 2022
@CarlSchwan
Copy link
Member

ci failure unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[24.0.0b2] Social buttons icons

5 participants