Remove call to already default php.ini values #32278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These values are already the default on supported PHP versions. I suggest to remove these calls.
CarlSchwan
approved these changes
May 5, 2022
solracsf
changed the title
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
CarlSchwan
requested review from
a team,
PVince81,
skjnldsv and
vanpertsch
and removed request for
a team
skjnldsv
approved these changes
May 12, 2022
skjnldsv
added
4. to release
This was referenced May 12, 2022
Member
|
Voting: This will break misconfigured servers in a maintenance update and the user might not even be able to change the value. |
Member
|
there probably isn't much value in backporting this, unless it fixes an important bug ? otherwise would consider tech debt and keep it solved only for 25 |
Member
|
We reverted it, so yeah should not backport either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These values are already the default on supported PHP versions.
I suggest to remove these calls.
https://www.php.net/manual/en/ini.core.php#ini.default-charset
https://www.php.net/manual/en/image.configuration.php#ini.gd.jpeg-ignore-warning