Skip to content

Conversation

@nickvergessen
Copy link
Member

Reverts #32278

Reverting this as it is saver to try to fix a php configuration then requiring users to do so (especially since they sometimes might not even be able to do so)

@nickvergessen nickvergessen added this to the Nextcloud 25 milestone May 16, 2022
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label May 16, 2022
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though in the case there they can't edit the php.ini, they certainly can't use ini_set

@nickvergessen nickvergessen requested a review from PVince81 May 23, 2022 08:17
@nickvergessen nickvergessen merged commit 8e59d49 into master Jun 3, 2022
@nickvergessen nickvergessen deleted the revert-32278-remove-default-php branch June 3, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants