Add api to register setup checks #32550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I like the idea 👍 Hopefully, we manage to finish this time #22527 🙈 |
come-nc
force-pushed
the
feat/api-cleanup-check
branch
from
3bd87a2 to
78ab85c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
come-nc
force-pushed
the
feat/api-cleanup-check
branch
2 times, most recently
from
bd23116 to
f2f4b84
Compare
Contributor
|
/compile / |
kesselb
reviewed
Oct 2, 2023
8 tasks
| IManager $manager, | ||
| IAppManager $appManager, | ||
| IServerContainer $serverContainer | ||
| IServerContainer $serverContainer, |
Check notice
Code scanning / Psalm
DeprecatedInterface
come-nc
force-pushed
the
feat/api-cleanup-check
branch
2 times, most recently
from
cddb318 to
bb49141
Compare
Contributor
|
I removed the new UI draft from the PR so that we can merge this in its current state. |
come-nc
requested review from
a team,
Altahrim and
icewind1991
and removed request for
a team
come-nc
added
3. to review
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Co-authored-by: Daniel <[email protected]> Signed-off-by: Côme Chilliet <[email protected]>
This will allow migrating checks to the new API without touching the UI for now. Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Had to remove tests for migrated checks, we should add tests for each SetupCheck class later on. Signed-off-by: Côme Chilliet <[email protected]>
For now we will keep the existing UI and only change the API behind it Signed-off-by: Côme Chilliet <[email protected]>
…ow results Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
…ates.php Co-authored-by: Benjamin Gaussorgues <[email protected]> Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
feat/api-cleanup-check
branch
from
1db2ae9 to
a3cc3b1
Compare
Tests could be simplified to test generic setup check directly with fake data instead of trying to mimic real steps results but for now this will do. Signed-off-by: Côme Chilliet <[email protected]>
Member
|
Docs would be cool on this one 😎 |
This was referenced Nov 29, 2023
13 tasks
come-nc
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an API for applications to register setup checks.
Rework setup checks UI.