Skip to content

Add api to register setup checks #32550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 24 commits into from
Oct 19, 2023
Merged

Add api to register setup checks #32550

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
eb1d612
Add api to register setup checks
CarlSchwan May 23, 2022
c71e47f
Progress
CarlSchwan May 30, 2022
0890012
Fix SetupChecks/LdapInvalidUuids.php
come-nc Sep 28, 2023
a3ec716
Fix UI and add PhpOutdated check
come-nc Sep 28, 2023
1202171
Fix docblock and types for new public API
come-nc Sep 28, 2023
b41b9cf
Small cleanups in SetupCheck classes
come-nc Sep 28, 2023
a56d40c
Fix lint problems in vue files
come-nc Sep 28, 2023
a4618cf
Move existing setup checks to new API
come-nc Oct 2, 2023
67e7a26
Fix PHPDoc in OCP for new SetupResult class
come-nc Oct 2, 2023
8bfa093
Migrate NeedsSystemAddressBookSync to new ISetupCheck API
come-nc Oct 2, 2023
bec6c0a
Migrate ReadOnlyConfig and DefaultPhoneRegionSet to new API
come-nc Oct 2, 2023
fa3c0e4
Fix description for SetupChecks/NeedsSystemAddressBookSync
come-nc Oct 9, 2023
05cb141
Merge setupchecks from new API into old UI
come-nc Oct 9, 2023
5503c4c
Add missing licences and copyright in SetupCheck
come-nc Oct 9, 2023
bd37067
Migrate InternetConnectivity check to new API
come-nc Oct 9, 2023
efa2dfa
Add OCP interface for SetupCheckManager
come-nc Oct 9, 2023
6bc3e00
Fix tests for setup checks
come-nc Oct 9, 2023
968b82c
Remove UI draft
come-nc Oct 12, 2023
be11ffd
Add debug logging when running setup checks to help with debugging sl…
come-nc Oct 16, 2023
6aa6f26
Move NeedsSystemAddressBookSync to dav application where it’s registered
come-nc Oct 16, 2023
11ebf46
Remove useless var in apps/settings/lib/SetupChecks/CheckUserCertific…
come-nc Oct 16, 2023
2e4d154
Change SetupResult API to named constructors
come-nc Oct 16, 2023
a3cc3b1
Small code style fix in SetupCheckManager
come-nc Oct 19, 2023
789ff3f
Fix jsunit tests for SetupChecks
come-nc Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Small cleanups in SetupCheck classes 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Oct 19, 2023
commit b41b9cf4c0da2e6e3c0502f51a5a9942ecff6fb3
7 changes: 4 additions & 3 deletions apps/settings/lib/SetupChecks/CheckUserCertificates.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,12 @@
use OCP\SetupCheck\SetupResult;

class CheckUserCertificates implements ISetupCheck {
private IL10N $l10n;
private string $configValue;

public function __construct(IL10N $l10n, IConfig $config) {
$this->l10n = $l10n;
public function __construct(
private IL10N $l10n,
IConfig $config,
) {
$configValue = $config->getAppValue('files_external', 'user_certificate_scan', '');
$this->configValue = $configValue;
}
Expand Down
13 changes: 5 additions & 8 deletions apps/settings/lib/SetupChecks/LegacySSEKeyFormat.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,11 @@
use OCP\SetupCheck\SetupResult;

class LegacySSEKeyFormat implements ISetupCheck {
private IL10N $l10n;
private IConfig $config;
private IURLGenerator $urlGenerator;

public function __construct(IL10N $l10n, IConfig $config, IURLGenerator $urlGenerator) {
$this->l10n = $l10n;
$this->config = $config;
$this->urlGenerator = $urlGenerator;
public function __construct(
private IL10N $l10n,
private IConfig $config,
private IURLGenerator $urlGenerator,
) {
}

public function getCategory(): string {
Expand Down
13 changes: 5 additions & 8 deletions apps/user_ldap/lib/SetupChecks/LdapInvalidUuids.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,11 @@
use OCP\SetupCheck\SetupResult;

class LdapInvalidUuids implements ISetupCheck {
private IL10N $l10n;
private UserMapping $userMapping;
private GroupMapping $groupMapping;

public function __construct(IL10N $l10n, UserMapping $userMapping, GroupMapping $groupMapping) {
$this->l10n = $l10n;
$this->userMapping = $userMapping;
$this->groupMapping = $groupMapping;
public function __construct(
private IL10N $l10n,
private UserMapping $userMapping,
private GroupMapping $groupMapping,
) {
}

public function getCategory(): string {
Expand Down