Skip to content

Handle non existing settings again #32655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CarlSchwan merged 1 commit into from
May 30, 2022
Merged

Handle non existing settings again #32655

CarlSchwan merged 1 commit into from
May 30, 2022

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented May 30, 2022

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label May 30, 2022
@CarlSchwan CarlSchwan requested review from a team and danxuliu May 30, 2022 08:52
@CarlSchwan CarlSchwan self-assigned this May 30, 2022
@CarlSchwan CarlSchwan requested review from blizzz, icewind1991 and skjnldsv and removed request for a team May 30, 2022 08:52
@CarlSchwan CarlSchwan mentioned this pull request May 30, 2022
Merged
2 tasks
@CarlSchwan CarlSchwan force-pushed the fix/handle-non-existing-settings branch from 9a6e1fa to 63f5891 Compare May 30, 2022 09:07
danxuliu
danxuliu approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@danxuliu
Copy link
Member

danxuliu commented May 30, 2022

/backport to stable24

@danxuliu
Copy link
Member

danxuliu commented May 30, 2022

/backport to stable23

PVince81
PVince81 approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CarlSchwan
Copy link
Member Author

CarlSchwan commented May 30, 2022

ci failures unrelated

@CarlSchwan CarlSchwan merged commit e86bcc8 into master May 30, 2022
@CarlSchwan CarlSchwan deleted the fix/handle-non-existing-settings branch May 30, 2022 10:53
This was referenced May 30, 2022
Merged
Merged
@nickvergessen
Copy link
Member

nickvergessen commented May 31, 2022

CI failure "NoDB" is related

@nickvergessen nickvergessen mentioned this pull request May 31, 2022
Merged
@nickvergessen
Copy link
Member

nickvergessen commented May 31, 2022

Follow up in #32667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@danxuliu danxuliu danxuliu approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@blizzz blizzz Awaiting requested review from blizzz

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@CarlSchwan CarlSchwan

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CarlSchwan @danxuliu @nickvergessen @PVince81