Skip to content

Handle non existing settings again #32655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlSchwan merged 1 commit into from
May 30, 2022
Merged

Handle non existing settings again #32655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Handle non existing settings again 
See #28189 (comment)

Signed-off-by: Carl Schwan <[email protected]>
  • Loading branch information
@CarlSchwan
CarlSchwan committed May 30, 2022
commit 63f589109bb114f285ad64ce8bc5a9ddbc4521e9
9 changes: 7 additions & 2 deletions lib/private/Settings/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,13 @@ protected function getSections(string $type): array {
}

foreach (array_unique($this->sectionClasses[$type]) as $index => $class) {
/** @var IIconSection $section */
$section = \OC::$server->get($class);
try {
/** @var IIconSection $section */
$section = $this->container->get($class);
} catch (QueryException $e) {
$this->log->info($e->getMessage(), ['exception' => $e]);
continue;
}

$sectionID = $section->getID();

Expand Down