Summer cleanup of the federation app #33007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Use IEventDispatcher instead of deprecated symfony dispatcher - Use LoggerInterface where possible - Use php 7.4 properties - Add type hinting where possible - Move federation hooks to a seperate listener Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
cleanup/federation-app
branch
from
860f32e to
a9cfa72
Compare
tcitworld
reviewed
Jun 24, 2022
Signed-off-by: Carl Schwan <[email protected]>
| * | ||
| * @return array | ||
| * Get all trusted servers | ||
| * @return list<array{id: int, url: string, url_hash: string, shared_secret: string, status: int, sync_token: string}> |
Check notice
Code scanning / Psalm
MoreSpecificReturnType
come-nc
approved these changes
Jun 27, 2022
- Return type were not correct - willReturn and with confusion Signed-off-by: Carl Schwan <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carl Schwan [email protected]