fix(dav): Run system address book create-if-not-exists in transaction #37965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| $this->atomic(function() use ($addressBookId, $cardUri, $vCard) { | ||
| $existingCard = $this->backend->getCard($addressBookId, $cardUri); | ||
| if ($existingCard === false) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
| $this->backend->deleteCard($addressBookId, $cardId); | ||
| $this->atomic(function() use ($addressBookId, $cardId, $user) { | ||
| $card = $this->backend->getCard($addressBookId, $cardId); | ||
| if ($card === false) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
tcitworld
approved these changes
May 2, 2023
Member
tcitworld
left a comment
tcitworld
left a comment
There was a problem hiding this comment.
Don't really like injecting IDBConnection here, but the alternative is catching UniqueConstraintViolationException for each insertion and do the update afterwards, which doesn't suit me much more.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced May 3, 2023
Merged
Closed
Merged
ChristophWurst
force-pushed
the
fix/transactional-system-addressbook-sync
branch
from
c37c76b to
e866a95
Compare
bigcat88
approved these changes
May 10, 2023
ChristophWurst
added
4. to release
nickvergessen
approved these changes
May 10, 2023
miaulalala
approved these changes
May 10, 2023
ChristophWurst
added
2. developing
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/transactional-system-addressbook-sync
branch
from
e866a95 to
2cc672d
Compare
ChristophWurst
added
4. to release
Contributor
|
CI failure unrelated |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@CarlSchwan Jun 24, 2022
TODO
Checklist