Move background settings from dashboard app to Appearance and accessibility settings #33733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Aug 29, 2022
juliusknorr
reviewed
Aug 29, 2022
juliusknorr
reviewed
Aug 29, 2022
juliusknorr
reviewed
Aug 29, 2022
juliusknorr
reviewed
Aug 29, 2022
juliusknorr
reviewed
Aug 29, 2022
This was referenced Aug 29, 2022
Closed
Merged
1 task
juliusknorr
reviewed
Sep 2, 2022
4 tasks
Pytal
changed the title
Pytal
force-pushed
the
change/appearance-accessibility-settings
branch
from
081b0bb to
6857126
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.
Member
|
Taking over and rebased for latest redesign changes |
GretaD
requested review from
CarlSchwan,
ChristophWurst,
marcoambrosini and
skjnldsv
PVince81
added
4. to release
nextcloud-command
force-pushed
the
change/appearance-accessibility-settings
branch
from
ae277d8 to
edd24af
Compare
Contributor
|
Conflicts... |
szaimen
added
2. developing
Member
|
ok, let me rebase and rebuild... |
PVince81
force-pushed
the
change/appearance-accessibility-settings
branch
from
edd24af to
c4fdce1
Compare
Member
|
@Pytal was this actually finished ? the label still says "2 to develop", please adjust accordingly and merge if applicable once ready |
Contributor
I added the label. It was finished |
szaimen
added
4. to release
Contributor
|
Failing tests seem related |
szaimen
added
2. developing
5 tasks
Pytal
force-pushed
the
change/appearance-accessibility-settings
branch
from
c4fdce1 to
2eecbda
Compare
Pytal
added
4. to release
Pytal
force-pushed
the
change/appearance-accessibility-settings
branch
2 times, most recently
from
b48b30c to
87fcbc9
Compare
…bility settings Signed-off-by: greta <[email protected]> Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
change/appearance-accessibility-settings
branch
from
87fcbc9 to
02cc42d
Compare
Contributor
|
CI failure unrelated |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #33736
Screenshot
To Do