Add global setting to disable keyboad shortcuts #34081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested review from
CarlSchwan,
PVince81,
marcoambrosini and
skjnldsv
This was referenced Sep 14, 2022
nickvergessen
requested review from
a team and
szaimen
and removed request for
a team
ChristophWurst
added
the
pending documentation
CarlSchwan
reviewed
Sep 14, 2022
CarlSchwan
approved these changes
Sep 14, 2022
Member
CarlSchwan
left a comment
CarlSchwan
left a comment
There was a problem hiding this comment.
Fine by me, make sure if you write doc about this that loadState('theming', 'shortcutsDisabled', false), needs to have a default value otherwise this will break when the theming app is disabled
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $this->initialStateService->provideLazyInitialState(Application::APP_ID, 'shortcutsDisabled', function () { | ||
| if ($this->userSession->getUser()) { | ||
| $uid = $this->userSession->getUser()->getUID(); | ||
| return $this->config->getUserValue($uid, Application::APP_ID, 'shortcuts_disabled', 'no') === 'yes'; |
Check notice
Code scanning / Psalm
PossiblyNullReference
PVince81
approved these changes
Sep 14, 2022
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 don't forget to remove the stray console.error
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Joas Schilling <[email protected]>
…earch and menu control Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/add-global-shortcuts-setting
branch
from
74b4c19 to
5267ea2
Compare
Member
Author
|
Rebased after #33733 And now with a global OCP method as discussed in nextcloud/contacts#2827 (comment) and chat |
Signed-off-by: Joas Schilling <[email protected]>
ChristophWurst
approved these changes
Sep 15, 2022
nickvergessen
added
the
4. to release
Merged
This was referenced Sep 15, 2022
nickvergessen
removed
the
pending documentation
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-requirement for nextcloud/spreed#7563
Fix #34079