LDAP to not register new users when outside of fair use or over limits #33945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Signed-off-by: Arthur Schiwon <[email protected]>
Member
Author
|
Downside of the current solution: With on-demand mapping, an end user may face an infinite spinner when trying to share a file, when a user would have to be mapped. The sharing frontend code does not handle well 500 results. My idea now is to perhaps react on the request: throw the exception only when the request is done via provisioning api, otherwise just skip mapping. |
- unbreaks functionality for end users when on demand mapping takes place Signed-off-by: Arthur Schiwon <[email protected]>
- do not stack notifications, replace them - and replace them once a day only - with LDAP it might end in total spam terror (also push) otherwise Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/noid/fair-use-ldap
branch
from
2fc503c to
7d3457e
Compare
blizzz
added
3. to review
Member
Author
|
/backport to stable25 |
Member
Author
|
/backport to stable24 |
szaimen
reviewed
Oct 20, 2022
PVince81
reviewed
Oct 21, 2022
PVince81
reviewed
Oct 21, 2022
Co-authored-by: Simon L. <[email protected]> Signed-off-by: blizzz <[email protected]>
szaimen
added
4. to release
Contributor
|
Can someone restart drone? Not sure if the failure is really related... |
Member
|
yeah, a bit weird: I've restarted the Drone builds |
This was referenced Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
UserManager::createUserwe check whether the instance is over limits (subscription or one-click-instance) and would refuse to add users. It works for local backends only. This PR offers a comfort method for assertion and makes the LDAP backend taking advantage of it.