Expose mapped user count from LDAP and use that for user limit check #34774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/fair-use-ldap-fix
branch
from
ed8dfa6 to
142f991
Compare
come-nc
added
3. to review
Contributor
Author
|
This fixes the user limit on ldap users by using the mapped user number instead of the number of users in the LDAP as a limit. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Côme Chilliet <[email protected]>
szaimen
reviewed
Oct 24, 2022
szaimen
approved these changes
Oct 24, 2022
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
I fear I can only give a 🐘 on this
Contributor
|
@come-nc autoloaders are not up-to-date... |
Co-authored-by: Simon L. <[email protected]> Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Contributor
Author
Fixed autoloaders. |
ArtificialOwl
approved these changes
Oct 25, 2022
Contributor
Author
|
/backport to stable25 |
Contributor
Author
|
/backport to stable24 |
Contributor
Author
|
/backport to stable25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #33945
Signed-off-by: Côme Chilliet [email protected]