fix public audio style #34055
fix public audio style #34055
Conversation
| margin-right: auto; | ||
| } | ||
|
|
||
| #imgframe:has(audio) { |
There was a problem hiding this comment.
this is such a useful selector 😍
There was a problem hiding this comment.
Just a note that firefox doesn't support this yet
https://caniuse.com/?search=has
There was a problem hiding this comment.
This is unfortunate! Do you have an idea for a better selector that works everywhere or maybe does @skjnldsv has one?
There was a problem hiding this comment.
I think you could also apply the margin on the .plyr element. That only shows when there's an audio file.
There was a problem hiding this comment.
I think you could also apply the margin on the
.plyrelement. That only shows when there's an audio file.
No, it also shows if there is a video where we do not want a margin... So what could be a solution to this?
There was a problem hiding this comment.
We can add a data-handler property to the #viewer element just like we do in the modal.
That will allow styling depending on the selected handler (audio, video, image, text, ...)
There was a problem hiding this comment.
Signed-off-by: szaimen <[email protected]>
szaimen
force-pushed
the
enh/noid/public-audio-style
branch
from
ee77d56 to
386d34e
Compare
|
/compile amend / |
Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
enh/noid/public-audio-style
branch
from
386d34e to
d40b5f5
Compare
szaimen
added
3. to review
szaimen
requested review from
a team,
PVince81,
Pytal,
max-nextcloud and
skjnldsv
and removed request for
a team
|
CI failure unrelated |
Follow-up to #34051
Signed-off-by: szaimen [email protected]