Skip to content

fix public audio style #34055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 2 commits into from
Sep 13, 2022
Merged

fix public audio style #34055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53a71e4
fix public audio style
szaimen Sep 13, 2022
d40b5f5
Compile assets
nextcloud-command Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/files_sharing/css/public.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/files_sharing/css/public.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions apps/files_sharing/css/public.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@ $download-button-section-height: 200px;
margin-right: auto;
}

#imgframe:has(audio) {
Copy link
Contributor Author

@szaimen szaimen Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is such a useful selector 😍

Copy link
Member

@pulsejet pulsejet Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that firefox doesn't support this yet
https://caniuse.com/?search=has

Copy link
Contributor Author

@szaimen szaimen Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunate! Do you have an idea for a better selector that works everywhere or maybe does @skjnldsv has one?

Copy link
Contributor

@max-nextcloud max-nextcloud Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could also apply the margin on the .plyr element. That only shows when there's an audio file.

Copy link
Contributor Author

@szaimen szaimen Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could also apply the margin on the .plyr element. That only shows when there's an audio file.

No, it also shows if there is a video where we do not want a margin... So what could be a solution to this?

Copy link
Contributor

@max-nextcloud max-nextcloud Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a data-handler property to the #viewer element just like we do in the modal.

That will allow styling depending on the selected handler (audio, video, image, text, ...)

Copy link
Contributor

@max-nextcloud max-nextcloud Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nextcloud/viewer#1371

// for speed settings
margin-top: 400px;
}

#imgframe .plyr {
top: 0px !important;
}

#imgframe .text-preview {
display: inline-block;
position: relative;
Expand Down
8 changes: 8 additions & 0 deletions apps/files_sharing/css/publicView.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/files_sharing/css/publicView.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.