Skip to content

Add includeTags to /share/id #34133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 3 commits into from
Sep 22, 2022
Merged

Add includeTags to /share/id #34133

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a4a387
Add includeTags to /share/id
tobiasKaminsky Sep 19, 2022
ebd28ef
Show include tags on single share
tobiasKaminsky Sep 19, 2022
5b3fb7a
Update apps/files_sharing/lib/Controller/ShareAPIController.php
tobiasKaminsky Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update apps/files_sharing/lib/Controller/ShareAPIController.php 
Co-authored-by: Joas Schilling <[email protected]>
Signed-off-by: Tobias Kaminsky <[email protected]>
  • Loading branch information
@tobiasKaminsky @nickvergessen
tobiasKaminsky and nickvergessen authored Sep 21, 2022
commit 5b3fb7a8ffccfddb5eaba2dcef9f974f066a6d44
6 changes: 4 additions & 2 deletions apps/files_sharing/lib/Controller/ShareAPIController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,10 +382,12 @@ public function getShare(string $id, bool $includeTags = false): DataResponse {
$share = $this->formatShare($share);

if ($includeTags) {
$share = Helper::populateTags(array($share), 'file_source', \OC::$server->getTagManager());
$share = Helper::populateTags([$share], 'file_source', \OC::$server->getTagManager());

Check notice

Code scanning / Psalm

DeprecatedMethod

The method OC\Server::getTagManager has been marked as deprecated
} else {
$share = [$share];
}

return new DataResponse([$share]);
return new DataResponse($share);
}
} catch (NotFoundException $e) {
// Fall through
Expand Down