Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

No description provided.

@tobiasKaminsky tobiasKaminsky marked this pull request as ready for review September 19, 2022 12:55
@tobiasKaminsky tobiasKaminsky added the 3. to review Waiting for reviews label Sep 19, 2022
@tobiasKaminsky tobiasKaminsky requested a review from a team September 19, 2022 12:56
Co-authored-by: Joas Schilling <[email protected]>
Signed-off-by: Tobias Kaminsky <[email protected]>
return new DataResponse([$share]);

if ($includeTags) {
$share = Helper::populateTags([$share], 'file_source', \OC::$server->getTagManager());

Check notice

Code scanning / Psalm

DeprecatedMethod

The method OC\Server::getTagManager has been marked as deprecated
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code looks good

@PVince81 PVince81 merged commit 938bc57 into master Sep 22, 2022
@PVince81 PVince81 deleted the showTag branch September 22, 2022 08:23
@blizzz blizzz mentioned this pull request Sep 22, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants