Skip to content

[stable25] Fix broken setup page layout #34197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PVince81 wants to merge 1 commit into from
Closed

[stable25] Fix broken setup page layout #34197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions core/css/guest.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,14 @@ form {
margin: auto;
padding: 0;
}
form fieldset {
Copy link
Member

@nickvergessen nickvergessen Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brutal last minute breaking of public page apps again?

Copy link
Member Author

@PVince81 PVince81 Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reverted a hunk from the original commit.

Really sad if that breaks the public page also 😢

Copy link
Member Author

@PVince81 PVince81 Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref df40fc9#diff-f661105ee785468b8919227c6b8a7c0e63c96106b3d06145160b1007b00a2f13L112

I had to change the width from 260 to 240px though

Copy link
Member Author

@PVince81 PVince81 Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't manage to make the selector more specific, if I change it to #body-login form fieldset it messes up the other field sets due to a change of specificity/priority.

and also whatever we do we should then retest the public pages with fields, like:

  • share link password entry
  • talk video verification
  • share by mail password request
  • ...

width: 240px;
margin-top: 8px;
-webkit-user-select: none;
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
}
form #sqliteInformation {
margin-top: 0px;
margin-bottom: 20px;
Expand Down Expand Up @@ -335,7 +343,7 @@ input[type='checkbox'].checkbox--white:checked + label:before {
display: inline-block;
position: relative;
top: -20px;
width: 286px;
width: 250px;
border-radius: 0 0 3px 3px;
overflow: hidden;
height: 3px;
Expand All @@ -350,7 +358,7 @@ input[type='checkbox'].checkbox--white:checked + label:before {
#show, #dbpassword-toggle {
position: absolute;
right: 2px;
top: 4px;
top: -3px;
display: flex;
justify-content: center;
width: 44px;
Expand Down