[stable25] Fix broken setup page layout #34197
Conversation
Bring back the fieldset styling glory. Recenter the sad eye. Destrenghten the strengthify container width. Signed-off-by: Vincent Petry <[email protected]>
|
/backport to master |
|
Probably @marcoambrosini should test with Safari as well |
| margin: auto; | ||
| padding: 0; | ||
| } | ||
| form fieldset { |
There was a problem hiding this comment.
Brutal last minute breaking of public page apps again?
There was a problem hiding this comment.
I just reverted a hunk from the original commit.
Really sad if that breaks the public page also 😢
There was a problem hiding this comment.
ref df40fc9#diff-f661105ee785468b8919227c6b8a7c0e63c96106b3d06145160b1007b00a2f13L112
I had to change the width from 260 to 240px though
There was a problem hiding this comment.
I didn't manage to make the selector more specific, if I change it to #body-login form fieldset it messes up the other field sets due to a change of specificity/priority.
and also whatever we do we should then retest the public pages with fields, like:
- share link password entry
- talk video verification
- share by mail password request
- ...
|
database tab might be offset/not-centered:
but it fit when 3 tabs are available:
|
|
password popup (mail/direct link) looks good:
|
blizzz
changed the title
|
Alternative patch #34222 |
|
alternate PR was merged |
Bring back the fieldset styling glory.
Recenter the sad eye.
Destrenghten the strengthify container width.
Please test locally to confirm that you see the same thing, just in case.