Skip to content

Add cache header for image endpoint if link previews #34215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Sep 28, 2022
Merged

Add cache header for image endpoint if link previews #34215

juliusknorr merged 1 commit into from
Sep 28, 2022

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Sep 23, 2022 •
edited
Loading

Saves requests for the link preview images

@juliusknorr juliusknorr requested review from a team, blizzz, come-nc, nickvergessen and skjnldsv and removed request for a team September 23, 2022 10:42
@juliusknorr juliusknorr added 3. to review Waiting for reviews bug labels Sep 23, 2022
@juliusknorr juliusknorr added this to the Nextcloud 26 milestone Sep 23, 2022
@juliusknorr
Copy link
Member Author

juliusknorr commented Sep 23, 2022

/backport to stable25

@juliusknorr juliusknorr mentioned this pull request Sep 23, 2022
Closed
blizzz
blizzz reviewed Sep 23, 2022
View reviewed changes
@juliusknorr juliusknorr force-pushed the bugfix/cache-headers-reference branch from 00c8504 to d4ae23e Compare September 23, 2022 10:55
@nickvergessen nickvergessen mentioned this pull request Sep 23, 2022
Merged
@juliusknorr juliusknorr force-pushed the bugfix/cache-headers-reference branch from d4ae23e to c49651c Compare September 28, 2022 10:02
@PVince81
Copy link
Member

PVince81 commented Sep 28, 2022

/rebase

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 28, 2022
@nextcloud-command nextcloud-command force-pushed the bugfix/cache-headers-reference branch from c49651c to f4a2ab1 Compare September 28, 2022 13:21
@juliusknorr
Copy link
Member Author

juliusknorr commented Sep 28, 2022

Failure is unrelated

@juliusknorr juliusknorr merged commit 1aa76e5 into master Sep 28, 2022
@juliusknorr juliusknorr deleted the bugfix/cache-headers-reference branch September 28, 2022 18:25
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 28, 2022
Merged
@julien-nc julien-nc mentioned this pull request Oct 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@blizzz blizzz blizzz approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

7 participants

@juliusknorr @PVince81 @nickvergessen @blizzz @skjnldsv @CarlSchwan