🏷️ /call/ reference provider #8001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
enhancement
feature: chat 💬
nickvergessen
requested review from
julien-nc,
juliusknorr,
marcoambrosini and
vitormattos
nickvergessen
commented
Sep 23, 2022
julien-nc
reviewed
Sep 23, 2022
julien-nc
approved these changes
Sep 23, 2022
Member
Author
|
nickvergessen
force-pushed
the
feature/noid/call-url-reference-provider
branch
from
42262d7 to
1481a19
Compare
vitormattos
reviewed
Sep 28, 2022
Comment on lines
81
to
87
| if (str_starts_with($referenceText, $indexPhpUrl)) { | ||
| $urlOfInterest = substr($referenceText, strlen($indexPhpUrl)) ?: null; | ||
| } elseif (str_starts_with($referenceText, $rewriteUrl)) { | ||
| $urlOfInterest = substr($referenceText, strlen($rewriteUrl)) ?: null; | ||
| } else { | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe will be good to put this in a separated method to make this method more simple.
Suggestion: extractUrlOfInterest
Member
Author
There was a problem hiding this comment.
I'm not really a fan of these micro functions where you have to jump around to see what the bigger picture does
marcoambrosini
approved these changes
Sep 28, 2022
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
feature/noid/call-url-reference-provider
branch
from
152edb1 to
0c7599f
Compare
vitormattos
approved these changes
Sep 29, 2022
Member
Author
|
/backport to stable25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7988
/call/…
/call/…#message_…
To get a closer preview the user needs to be a participant (open conversation or public link are not enough, in those cases the above information is shown)