Skip to content

includeTags -> include_tags #34223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 1 commit into from
Oct 1, 2022
Merged

includeTags -> include_tags #34223

blizzz merged 1 commit into from
Oct 1, 2022

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Sep 23, 2022

Follow up to #34133

I realized that the other api /shares uses "include_tags", so we should use the same parameter.

Signed-off-by: tobiasKaminsky [email protected]

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Sep 23, 2022

/backport to stable-25

@tobiasKaminsky tobiasKaminsky added the 3. to review Waiting for reviews label Sep 23, 2022
@tobiasKaminsky tobiasKaminsky marked this pull request as ready for review September 23, 2022 13:55
@tobiasKaminsky tobiasKaminsky mentioned this pull request Sep 23, 2022
Merged
2 tasks
PVince81
PVince81 approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

PVince81 commented Sep 23, 2022

/backport to stable25

@PVince81 PVince81 assigned PVince81 and unassigned PVince81 Sep 23, 2022
@PVince81 PVince81 added this to the Nextcloud 25 milestone Sep 23, 2022
@blizzz blizzz mentioned this pull request Sep 27, 2022
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 27, 2022
@blizzz
Copy link
Member

blizzz commented Sep 27, 2022

CI is unhappy

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Sep 27, 2022

Node: Binary files a/dist/dashboard-main.js.map and b/dist/dashboard-main.js.map differ

I have no experience in your CI, but this looks like a flaky test or something unrelated.

@blizzz
Copy link
Member

blizzz commented Sep 27, 2022

I have no experience in your CI, but this looks like a flaky test or something unrelated.

yes, indeed, spotted it now somewhere else, too, but this to be fixed meanwhile as well.

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 27, 2022
@PVince81
Copy link
Member

PVince81 commented Sep 28, 2022

/rebase

@tobiasKaminsky @PVince81
includeTags -> include_tags
610bbae 
Signed-off-by: tobiasKaminsky <[email protected]>
@blizzz blizzz merged commit 2b854c1 into master Oct 1, 2022
@blizzz blizzz deleted the includeTags branch October 1, 2022 19:43
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 1, 2022

The backport to stable-25 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 1, 2022

The backport to stable25 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@blizzz blizzz blizzz approved these changes

@come-nc come-nc Awaiting requested review from come-nc

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

5 participants

@tobiasKaminsky @PVince81 @blizzz @skjnldsv