Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #34222

@szaimen
Copy link
Contributor

szaimen commented Sep 26, 2022

/rebase

1 similar comment
@szaimen
Copy link
Contributor

szaimen commented Sep 26, 2022

/rebase

- Use normal labels instead of hiding them
- Fix position of the eye button (this is still very hacky)
- Define width on the box and not on the text fields

This really needs to be ported to vue

Signed-off-by: Carl Schwan <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@blizzz blizzz mentioned this pull request Sep 27, 2022
@blizzz blizzz added the 3. to review Waiting for reviews label Sep 27, 2022
@nickvergessen nickvergessen removed their request for review September 27, 2022 09:22
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 27, 2022
@blizzz blizzz merged commit 96423a1 into stable25 Sep 27, 2022
@blizzz blizzz deleted the backport/34222/stable25 branch September 27, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants