Fix install page #34222
Merged
Fix install page #34222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
added
3. to review
CarlSchwan
requested review from
PVince81,
Pytal and
skjnldsv
and removed request for
a team
Member
|
it is likely that adding an "Oracle" option will shift the whole thing again, but not a big issue anyway |
PVince81
added
4. to release
CarlSchwan
force-pushed
the
fix/install-page
branch
from
58a1b82 to
5276934
Compare
Pytal
approved these changes
Sep 23, 2022
This comment was marked as resolved.
This comment was marked as resolved.
nextcloud-command
force-pushed
the
fix/install-page
branch
from
5276934 to
7b83b55
Compare
Member
|
/compile amend / |
- Use normal labels instead of hiding them - Fix position of the eye button (this is still very hacky) - Define width on the box and not on the text fields This really needs to be ported to vue Signed-off-by: Carl Schwan <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/install-page
branch
from
7b83b55 to
d358efc
Compare
Member
Author
|
ci failure unrelated |
Member
Author
|
/backport to stable25 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This really needs to be ported to vue
Less likely to break stuff compared to #34197 as everything is prefixed with a class specific to the installer