Skip to content

[stable23] Detect weird local ips #35144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
come-nc merged 8 commits into from
Nov 21, 2022
Merged

[stable23] Detect weird local ips #35144

come-nc merged 8 commits into from
Nov 21, 2022

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 14, 2022 •
edited
Loading

@come-nc
Harden tests for local IP detection in URLs
1c58ba5 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Add missing urldecode and idn_to_utf8 calls to local address checker
72f60a6 
The call to idn_to_utf8 call is actually to apply normalization

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Use new dependency to normalize IPs
be07051 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Fix tests for nested v4 in v6
96d3d09 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Fix idn_to_utf8 stub signature
5eddbac 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc
Add mlocati/ip-lib dependency
8360bb8 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc self-assigned this Nov 14, 2022
@come-nc come-nc changed the base branch from master to stable23 November 14, 2022 10:29
@come-nc come-nc force-pushed the backport/34160/stable23 branch from 5755f76 to 8360bb8 Compare November 14, 2022 10:31
@come-nc come-nc changed the title Backport/34160/stable23 [stable23] Detect weird local ips Nov 14, 2022
@come-nc come-nc requested review from a team, ArtificialOwl, blizzz, nickvergessen and skjnldsv and removed request for a team November 14, 2022 10:38
@come-nc
Copy link
Contributor Author

come-nc commented Nov 14, 2022 

There was 1 failure:
201	
202	1) Test\Http\Client\LocalAddressCheckerTest::testThrowIfLocalAddress with data set #20 ('127。②⑤④。⑯⑨.②⑤④')
203	Failed asserting that exception of type "OCP\Http\Client\LocalServerException" is thrown.

@come-nc
Copy link
Contributor Author

come-nc commented Nov 15, 2022 

There was 1 failure:
201	
202	1) Test\Http\Client\LocalAddressCheckerTest::testThrowIfLocalAddress with data set #20 ('127。②⑤④。⑯⑨.②⑤④')
203	Failed asserting that exception of type "OCP\Http\Client\LocalServerException" is thrown.

Seems specific to 7.3, should be fixed by last commit

szaimen
szaimen approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@come-nc come-nc marked this pull request as ready for review November 17, 2022 15:55
@come-nc come-nc enabled auto-merge November 17, 2022 15:55
@come-nc come-nc disabled auto-merge November 21, 2022 08:33
@come-nc come-nc merged commit 37d8496 into stable23 Nov 21, 2022
@come-nc come-nc deleted the backport/34160/stable23 branch November 21, 2022 08:33
@come-nc come-nc added this to the Nextcloud 23.0.12 milestone Nov 21, 2022
@blizzz blizzz mentioned this pull request Nov 21, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@blizzz blizzz blizzz approved these changes

@szaimen szaimen szaimen approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@come-nc come-nc

Labels

None yet

Projects

None yet

Milestone

Nextcloud 23.0.12

Development

Successfully merging this pull request may close these issues.

5 participants

@come-nc @nickvergessen @blizzz @szaimen