Skip to content

[stable23] Detect weird local ips #35144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 8 commits into from
Nov 21, 2022
Merged

[stable23] Detect weird local ips #35144

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1c58ba5
Harden tests for local IP detection in URLs
come-nc Sep 20, 2022
72f60a6
Add missing urldecode and idn_to_utf8 calls to local address checker
come-nc Sep 20, 2022
be07051
Use new dependency to normalize IPs
come-nc Sep 20, 2022
96d3d09
Fix tests for nested v4 in v6
come-nc Sep 20, 2022
5eddbac
Fix idn_to_utf8 stub signature
come-nc Sep 22, 2022
8360bb8
Add mlocati/ip-lib dependency
come-nc Nov 14, 2022
6bdb5d2
Pass default values to idn_to_utf8 to fix behavior under PHP 7.3
come-nc Nov 15, 2022
b5c8efa
Update 3rdparty to latest stable23
come-nc Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Harden tests for local IP detection in URLs 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Nov 14, 2022
commit 1c58ba500b4edb905b94ef920faaad9b7c3e59a1
1 change: 1 addition & 0 deletions tests/lib/Http/Client/ClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ public function dataPreventLocalAddress():array {
['another-host.local'],
['service.localhost'],
['!@#$'], // test invalid url
['normal.host.com'],
];
}

Expand Down
19 changes: 19 additions & 0 deletions tests/lib/Http/Client/LocalAddressCheckerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,25 @@ public function dataPreventLocalAddress():array {
['100.100.100.200'],
['192.0.0.1'],
['randomdomain.internal'],
['0177.0.0.9'],
['⑯⑨。②⑤④。⑯⑨｡②⑤④'],
['127。②⑤④。⑯⑨.②⑤④'],
['127.0.00000000000000000000000000000000001'],
['127.1'],
['127.000.001'],
['0177.0.0.01'],
['0x7f.0x0.0x0.0x1'],
['0x7f000001'],
['2130706433'],
['00000000000000000000000000000000000000000000000000177.1'],
['0x7f.1'],
['127.0x1'],
['[0000:0000:0000:0000:0000:0000:0000:0001]'],
['[0:0:0:0:0:0:0:1]'],
['[0:0:0:0::0:0:1]'],
['%31%32%37%2E%30%2E%30%2E%31'],
['%31%32%37%2E%30%2E%30.%31'],
['[%3A%3A%31]'],
];
}

Expand Down