Fix dynamic properties and other problems in tests for PHP 8.2 #35156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
requested review from
a team,
ArtificialOwl,
blizzz and
skjnldsv
and removed request for
a team
blizzz
reviewed
Nov 14, 2022
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
a few remarks, also CI isn't convinced.
tcitworld
reviewed
Nov 14, 2022
Signed-off-by: Côme Chilliet <[email protected]>
…st.php Signed-off-by: Côme Chilliet <[email protected]>
Many editors remove trailing whitespaces, so avoid depending on them for tests success. Signed-off-by: Côme Chilliet <[email protected]>
blizzz
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #32595
See #32463
Signed-off-by: Côme Chilliet [email protected]